remove non root user

srl-labs · Jun 2, 2024 · 7a3cbe9 · 7a3cbe9
1 parent 3da41c9
commit 7a3cbe9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.github/containers/dind/.devcontainer/Dockerfile b/.github/containers/dind/.devcontainer/Dockerfile
@@ -10,5 +10,5 @@ RUN apt update && apt install -y --no-install-recommends \
     containerlab
 
 # Switch to user
-USER user
-ENV PATH=$PATH:/home/${USERNAME}/.local/bin
+# USER user
+# ENV PATH=$PATH:/home/${USERNAME}/.local/bin
diff --git a/.github/containers/dind/.devcontainer/devcontainer.json b/.github/containers/dind/.devcontainer/devcontainer.json
@@ -8,6 +8,16 @@
         // }
     },
     "features": {
+        "ghcr.io/devcontainers/features/common-utils:2": {
+            "installZsh": true,
+            "installOhMyZsh": true,
+            "configureZshAsDefaultShell": true,
+            // "username": "${localEnv:USERNAME}",
+            // "userUid": "${localEnv:UID}",
+            // "userGid": "${localEnv:GID}",
+            // do not update packages to reduce build time
+            "upgradePackages": "false"
+        },
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
             "version": "latest",
             "dockerDashComposeVersion": "none"