Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carlmontanari I screwed up vxlan tunneling with #16
The tunnels.yml used service name without
-vx
suffix that was added. I added it in this PR but it still flaky, because somehow the clusterIP services now use the obj.Name assrl1-vx
and not justsrl1
.This screws service selectors:
I am a bit lost here. Why the obj name here now
srl1-vx
? And how to make it better?clabernetes/controllers/topology/servicefabric.go
Line 228 in cf4774a