Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing service renaming #20

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fixing service renaming #20

merged 2 commits into from
Sep 20, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Sep 20, 2023

@carlmontanari I screwed up vxlan tunneling with #16
The tunnels.yml used service name without -vx suffix that was added. I added it in this PR but it still flaky, because somehow the clusterIP services now use the obj.Name as srl1-vx and not just srl1.

This screws service selectors:

apiVersion: v1
kind: Service
metadata:
  creationTimestamp: "2023-09-20T10:09:46Z"
  labels:
    clabernetes/app: clabernetes
    clabernetes/name: clab-srl02-srl2-vx
    clabernetes/topologyNode: srl2-vx
    clabernetes/topologyOwner: clab-srl02
    clabernetes/topologyServiceType: fabric
  name: clab-srl02-srl2-vx
  namespace: srl02
  ownerReferences:
  - apiVersion: topology.clabernetes/v1alpha1
    kind: Containerlab
    name: clab-srl02
    uid: 136a9911-841f-4dc3-8050-3bd9e15fd493
  resourceVersion: "244739"
  uid: 3be44f91-9282-4886-940c-87d0ecc14dbe
spec:
  clusterIP: 10.96.77.24
  clusterIPs:
  - 10.96.77.24
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: vxlan
    port: 4789
    protocol: UDP
    targetPort: 4789
  selector:
    clabernetes/topologyNode: srl2-vx
    clabernetes/topologyOwner: clab-srl02
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

I am a bit lost here. Why the obj name here now srl1-vx? And how to make it better?

@carlmontanari
Copy link
Contributor

I think fix pushed, give that a whack :p

@hellt hellt marked this pull request as ready for review September 20, 2023 16:06
@hellt hellt merged commit 8610f5d into main Sep 20, 2023
3 checks passed
@carlmontanari carlmontanari deleted the rename-svc-pt2 branch September 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants