Skip to content

Commit

Permalink
fix: e2e test was trying to get obj outside of eventually bad idea :p
Browse files Browse the repository at this point in the history
  • Loading branch information
carlmontanari committed Oct 16, 2023
1 parent ede72fd commit 4565916
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions e2e/suite/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
const (
updateReconcileWait = 2 * time.Second
eventuallyPollInterval = 3 * time.Second
eventuallyMaxTime = 60 * time.Second
eventuallyMaxTime = 120 * time.Second
)

// Run executes a clabernetes e2e test.
Expand Down Expand Up @@ -47,11 +47,11 @@ func Run(t *testing.T, steps []Step, testName string) { //nolint: thelper
for idx := range objects {
object := step.AssertObjects[kind][idx]

objectData := getter(t, namespace, kind, object.Name, object)

fileName := fmt.Sprintf("golden/%d-%s.%s.yaml", step.Index, kind, object.Name)

if *clabernetestesthelper.Update {
objectData := getter(t, namespace, kind, object.Name, object)

clabernetestesthelper.WriteTestFixtureFile(t, fileName, objectData)

// we just wrote the golden file of course it will match, no need to check
Expand Down

0 comments on commit 4565916

Please sign in to comment.