-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cabal2nix
integration for IFD-less evalutation
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
reviewed
Dec 8, 2024
Open
15 tasks
srid
reviewed
Dec 16, 2024
srid
reviewed
Dec 16, 2024
srid
changed the title
feat: IFD-less evalutation
feat: Dec 16, 2024
cabal2nix
integration for IFD-less evalutation
srid
reviewed
Dec 16, 2024
srid
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
As a last thing, could add a test?
srid
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just wanting on the other PRs to be merged. And then I'll test it on some of my projects before merging.
srid
force-pushed
the
cache-cabal2nix
branch
3 times, most recently
from
December 23, 2024 01:58
f47c91a
to
0327c07
Compare
srid
force-pushed
the
cache-cabal2nix
branch
from
December 23, 2024 02:01
0327c07
to
e9e64e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #144 just for local packages. IFD will still be used for Hackage packages (
callHackage
) and custom source inputs.Example: srid/haskell-template#146