draft: Split MCE into modules #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! i will trust you on the code functionality for this one but the concept seems fine so ok for me just one thing, maybe rename the files directly without the |
|
I added a prefix because I plan to do the NE aswell with the same structure. It was for maybe avoid mistake, should i remove the prefix anyway? |
|
yeah you can just create a "ne" folder and do the same so you can remove prefixes |
maxime1907
reviewed
Jul 31, 2024
|
mapchooser_extended.sp(74) : error 417: cannot read from file: "mce/natives.inc" |
|
|
you forgot to rename the natives file name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any reviews @maxime1907 ?