Add getter to TZDateTime for native DateTime #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows retrieval of the equivalent native DateTime object
srawlins
requested changes
Apr 3, 2024
| @@ -50,6 +50,9 @@ class TZDateTime implements DateTime { | |||
| /// Represents the same moment as this [TZDateTime]. | |||
| final DateTime _native; | |||
|
|
|||
| /// Returns a native DateTime object representing this same point in time. | |||
| DateTime get native => _native; | |||
There was a problem hiding this comment.
You can just make the field above public, instead of having a field and getter.
https://dart.dev/effective-dart/usage#prefer-using-a-final-field-to-make-a-read-only-property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows retrieval of the equivalent native DateTime object. I'm using TZDateTime on conjunction with third-party libraries that specifically check for the exact type of DateTime, so this is needed to efficiently get the underlying native DateTime.