Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.5 Fabric #33

Draft
wants to merge 28 commits into
base: 1.16-fabric
Choose a base branch
from
Draft

Conversation

CoolMineman
Copy link

Fixes #32
Fixes #31
Fixes #26 (Also fixes Slow Falling)
Related #21

@squeek502
Copy link
Owner

Nice work! Will test it out soon.

@CoolMineman CoolMineman marked this pull request as draft February 12, 2021 03:26
@CoolMineman
Copy link
Author

need to fix some merge issues first still

@CoolMineman
Copy link
Author

Seems to be working again now, QuakeClientPlayer seemed to have completely broken post merge so I copy and pasted my old version.

@squeek502
Copy link
Owner

squeek502 commented Feb 16, 2021

Looks like there's still some stuff to work out with water movement (the same stuff I haven't figured out how to solve):

@CoolMineman
Copy link
Author

Should be better now

CoolMineman and others added 2 commits February 20, 2021 15:08
Adds GitHub Action that compiles every commit and releases artifacts if successful.
@Timwun
Copy link

Timwun commented Jun 23, 2021

Hey, whats up with this PR?

@CoolMineman @squeek502

@squeek502
Copy link
Owner

Sharking is still not working the same as it was in previous versions. What I should probably do is just scratch sharking for the initial port and just release something; the sharking stuff probably needs a complete rewrite at this point.

@Timwun
Copy link

Timwun commented Jun 24, 2021

This would be awesome! I think sharking is something important but I would just sacrifice it for an initial release.

Also I would love to see if the mod works in 1.17 as well. Fabric is already out. :D

P.S.: Thanks for the mod! ❤️

@davidalb97
Copy link

To avoid server crashing at startup, add @Environment(EnvType.CLIENT) to ModQuakeMovement.drawSpeedometer() to the method signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants