Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Add setter for ProtoDefaulted and CustomDefaulted #2682

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dnkoutso
Copy link
Collaborator

No description provided.

@dnkoutso dnkoutso requested a review from lickel October 16, 2023 21:54
@@ -1160,7 +1160,7 @@ class SwiftGenerator private constructor(
.build()

fileMembers += FileMemberSpec.builder(memberwiseExtension)
.addGuard("$FLAG_INCLUDE_MEMBERWISE_INITIALIZER")
.addGuard(FLAG_INCLUDE_MEMBERWISE_INITIALIZER)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning fix

@@ -1256,7 +1256,7 @@ class SwiftGenerator private constructor(
.build()

fileMembers += FileMemberSpec.builder(memberwiseExtension)
.addGuard("$FLAG_INCLUDE_MEMBERWISE_INITIALIZER")
.addGuard(FLAG_INCLUDE_MEMBERWISE_INITIALIZER)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning fix

@dnkoutso dnkoutso merged commit 86caab7 into master Oct 16, 2023
12 of 13 checks passed
@dnkoutso dnkoutso deleted the use_setters_for_defaults branch October 16, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants