Don't crash in the Gradle plugin assigning isCanBeConsumed #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is attempting to prevent this crash:
org.gradle.api.GradleException: Cannot change the allowed usage of configuration ':protos:protoSourceCopy', as it was locked upon creation to the role: 'Custom Role'.
This role permits the following usage:
Consumable - this configuration can be selected by another project as a dependency (but this behavior is marked deprecated)
Resolvable - this configuration can be resolved by this project to a set of files
Declarable Against - this configuration can have dependencies added to it
Ideally, each configuration should be used for a single purpose.
at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.assertUsageIsMutable(DefaultConfiguration.java:1787)
at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.preventIllegalMutation(DefaultConfiguration.java:1556)
at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.validateMutation(DefaultConfiguration.java:1510)
at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.setCanBeConsumed(DefaultConfiguration.java:1866)
at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration_Decorated.setCanBeConsumed(Unknown Source)
at com.squareup.wire.gradle.WirePlugin.setupWireTasks(WirePlugin.kt:147)
I believe the root cause is a regression fixed in Gradle 8.4
gradle/gradle@edc8ab0
|
I’m gonna check if upgrading to Gradle 8.4 fixes this so I don’t need to take further action. |
|
This is unnecessary. Upgrading to Gradle 8.4 is sufficient. |
|
Related to #2676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is attempting to prevent this crash:
I believe the root cause is a regression fixed in Gradle 8.4 gradle/gradle@edc8ab0