Import response type keeper #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.apt.2024-01-29
branch
from
de9edef
to
466d24d
Compare
This annotation processor parses all types used as response bodies in Retrofit service methods and adds a keep rule for them. This ensures that even if the type isn't used by callers, it is kept and used to parse the body.
JakeWharton
force-pushed
the
jw.apt.2024-01-29
branch
from
466d24d
to
e13f655
Compare
swankjesse
reviewed
Feb 2, 2024
| returnType.recursiveParameterizedTypesTo(referenced) | ||
|
|
||
| // Retrofit has special support for 'suspend fun' in Kotlin which manifests as a | ||
| // final Continuation parameter whose generic type is the declared return type. |
swankjesse
reviewed
Feb 2, 2024
|
|
||
| for ((element, referencedTypes) in elementToReferencedTypes) { | ||
| val typeName = element.qualifiedName.toString() | ||
| val outputFile = "META-INF/proguard/retrofit-response-type-keeper-$typeName.pro" |
There was a problem hiding this comment.
This is surprising but makes sense.
swankjesse
reviewed
Feb 2, 2024
|
|
||
| @Test | ||
| fun kotlinSuspend() { | ||
| val service = JavaFileObjects.forSourceString( |
swankjesse
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation processor parses all types used as response bodies in Retrofit service methods and adds a keep rule for them. This ensures that even if the type isn't used by callers, it is kept and used to parse the body.
Closes #3588
We have been using this internally on Cash for a few years now. I've expanded its support to cover all Retrofit annotations as well as written actual tests (gasp!).