Support for Flutter 3, Android 12 and most recent iOS SDK #93
Conversation
|
|
TatsuUkraine
changed the title
|
@hukid don't know who is the best person to review, merge, and release a new version to pub.dev |
|
@JonathanNakhla-Square hi, maybe you know who is responsible for the flutter plugin and has the ability to publish new versions to pub.dev? |
|
@TatsuUkraine Any additional updates on publishing the new version to pub.dev yet? |
|
@nick-happsnow I don't think so, unless you want me to add anything to the docs? |
|
Ah, I thought you asking me if I want to add anything before publishing)) no, I didn't receive any updates yet |
|
@TatsuUkraine Ok thanks. Hopefully this can get on pub.dev soon! |
@TatsuUkraine , thanks for making the fix. @CharmisG and I will review the change. Hopefully we can merge the change soon if no issue found. |
| @@ -187,6 +138,9 @@ information on installing Reader SDK for iOS, see the | |||
| --app-id YOUR_SQUARE_READER_APP_ID \ | |||
| --repo-password YOUR_SQUARE_READER_REPOSITORY_PASSWORD | |||
| ``` | |||
|
|
|||
| Optionally you can use `--version` key to specify what version of iOS Reader SDK | |||
| 'FRAMEWORK_SEARCH_PATHS[sdk=iphoneos*]' => '$(PROJECT_DIR)/../SquareReaderSDK.xcframework/ios-arm64', | ||
| 'FRAMEWORK_SEARCH_PATHS[sdk=iphonesimulator*]' => '$(PROJECT_DIR)/../SquareReaderSDK.xcframework/ios-x86_64-simulator' | ||
| } | ||
| s.xcconfig = { |
|
@hukid hi, I left comments on some items in your review. I didn't find updated SDK requirements after 1.6.2 was released so I left targetSDK equal to the value our project is currently running on. Do you still want to change targetSdk to 31? Since SDK 32 works for us so I thought that It would be good to keep max possible value there. P.S I tried target SDK 33 but due to storage permission changes Reader SDK currently can't work with it( |
|
@hukid changed target SDK to 31 in the plugin, example project, and docs |
|
@TatsuUkraine |
|
@CharmisG yes, it works on both android and ios |
|
@hukid |
|
@TatsuUkraine |
|
@TatsuUkraine we have one more PR to merge, and we'll release. |
|
@TatsuUkraine @nick-happsnow we just released the new version. Please take a look. |
Summary
IMPORTANT Requires 4.x version publish to pub.dev since it has breaking changes related to Android configuration (see Migration guide)
Related issues
Fix #92, Fix #80, Fix #91
Changelog
Test Plan
Manually test the quick start example works with Flutter 3 on Android 12 and 13 and with iOS simulator