-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated targetSDK to 34 #114
base: master
Are you sure you want to change the base?
Conversation
2ca29e4
to
851c6a9
Compare
Looks like we need to update/upload the provisioning profiles so the github actions can access them. |
updated run script fixing pipelines for ios fixing pipeling for minifyEnable fixing lint error for camera permission in pipelines fixing notification permissions issue in pipelines fixing proguard issue in pipeline
851c6a9
to
1f39e5e
Compare
Bump reader sdk version to fetch for ios build and update xcodebuild to not code sign example app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think you just need to update the Changelog with the changes to 4.0.2
@@ -1,5 +1,9 @@ | |||
## Changelog | |||
|
|||
### v4.0.2 Sep 18, 2024 | |||
|
|||
* Upgrade to Reader SDK 1.7.7 on Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this version also update to 1.7.4 on iOS?
1. changed targetSdk to 342. changed graddle plugin to 8.7 and other dependencies to make the example app run on android
3. updated the dependencies permission_handler, barcode_scan2, firebase_core to make it compatible with SDK 34
4. updated platform :ios to 13.1 in Podfile to run the example of iOS
First three changes has been extracted into a separate PR #117 for android-only changes to support SDK 34.
This PR is now only about the iOS changes