-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-214] Add Support for Power Tracing #215
Conversation
This patch adds support to PyLink for using the Power Trace API.
if isinstance(channels, list): | ||
channel_mask = 0x00 | ||
for channel in channels: | ||
channel_mask |= (1 << channel) | ||
else: | ||
channel_mask = channels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test the channel values are in the range of 0-7?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah. Are you thinking of filtering out the values outside of the range, or raising a ValueError
? I think either could work here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking along the lines of a ValueError
or just an assert
.
Hi, My observations (not relevant to pylink):
|
[ISSUE-214] Add Support for Power Tracing
Overview
This PR adds support to PyLink for using the Power Trace API. Example usage:
Summary of Changes
pylink/__main__.py
to handle old and newsix
withwith_metaclass
.