Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Assets or Resources based on platform. #8636

Open
wants to merge 10 commits into
base: remove_android
Choose a base branch
from
Open

Use Assets or Resources based on platform. #8636

wants to merge 10 commits into from

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Dec 27, 2024 •
edited
Loading

Assets uncompressed on Android. Assuming that the AAR file will compress.

Use Resources, compressed on JVM.

Includes an Androidx Startup Initializer a ContentProvider to grab the app context.

@yschimke yschimke requested a review from swankjesse December 27, 2024 18:04
@yschimke yschimke added the android Relates to usage specifically on Android label Dec 27, 2024
@yschimke
Use Assets and Resources based on platform.
4dc8f79 
Assets uncompressed on Android. Assuming that the AAR file will compress.

Use Resources, compressed on JVM.
@yschimke
Fix tests
131ff8d
@yschimke yschimke changed the title Use Assets and Resources based on platform. Use Assets or Resources based on platform. Dec 27, 2024
@yschimke
Copy link
Collaborator Author

Androidx Startup approach fails with

https://github.com/square/okhttp/actions/runs/12520208963/job/34925534823?pr=8636

Execution failed for task ':okhttp:animalsnifferMain'.
> Could not resolve all files for configuration ':okhttp:compileClasspath'.
   > Could not resolve androidx.startup:startup-runtime:1.2.0.
     Required by:
         project :okhttp
      > No matching variant of androidx.startup:startup-runtime:1.2.0 was found. The consumer was configured to find a library for use during compile-time, compatible with Java 8, preferably in the form of class files, preferably optimized for standard JVMs, and its dependencies declared externally but:

@yschimke yschimke requested a review from JakeWharton December 28, 2024 11:06
yschimke
yschimke commented Dec 28, 2024
View reviewed changes
okhttp/build.gradle.kts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse Awaiting requested review from swankjesse

@JakeWharton JakeWharton Awaiting requested review from JakeWharton

Assignees
No one assigned
Labels
android Relates to usage specifically on Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke