Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2661] Fix BroadcastReceiver ANR at ScreenOffTrigger #2732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[2661] Fix BroadcastReceiver ANR at ScreenOffTrigger #2732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions leakcanary/leakcanary-android-release/src/main/java/leakcanary/ScreenOffTrigger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,20 +42,20 @@ class ScreenOffTrigger(
context: Context,
intent: Intent
) {
if (intent.action == ACTION_SCREEN_OFF) {
if (currentJob == null) {
val job =
analysisClient.newJob(JobContext(ScreenOffTrigger::class))
currentJob = job
analysisExecutor.execute {
analysisExecutor.execute {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If analysisExecutor.execute runs the task quickly enough, there's a chance that we might dump the heap & freeze the VM before the process has had a chance to report back to system_server, right?

Looks to me like if we want to avoid that, we need to execute with a delay instead"?

if (intent.action == ACTION_SCREEN_OFF) {
if (currentJob == null) {
val job =
analysisClient.newJob(JobContext(ScreenOffTrigger::class))
currentJob = job
val result = job.execute()
currentJob = null
analysisCallback(result)
}
} else {
currentJob?.cancel("screen on again")
currentJob = null
}
} else {
currentJob?.cancel("screen on again")
currentJob = null
}
}
}
Expand Down
Loading