Extract trait interface for annotatable constructs and their builders #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
May 23, 2023
| public fun addAnnotation(annotationSpec: AnnotationSpec): Builder = apply { | ||
| override fun addAnnotation(annotationSpec: AnnotationSpec): Builder = apply { |
There was a problem hiding this comment.
This override can be bypassed by mutating the collection directly. Should probably move the validation to the builder, but that's a separate issue.
JakeWharton
commented
May 23, 2023
JakeWharton
force-pushed
the
jw.annotatable.2023-05-23
branch
from
d65e5cd to
422e62b
Compare
Egorand
approved these changes
May 24, 2023
JakeWharton
force-pushed
the
jw.annotatable.2023-05-23
branch
from
422e62b to
3957307
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1553