This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
MethodSpec factory for overriding an ExecutableElement. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, two questions:
Copying type annotations seems like an obvious yes but we don't support that yet (#136). |
|
Make sure you don't get two On copying over annotations, we should do what IntelliJ does: copy 'em. Though we need API to remove annotations too. On testing, can you do what TypesTest does to get Elements for the current file? |
JakeWharton
force-pushed
the
jw/override
branch
from
885ab84 to
5397ca2
Compare
|
PTAL. Copying annotations requires non-trivial infrastructure around being able to create |
JakeWharton
force-pushed
the
jw/override
branch
from
5397ca2 to
561e389
Compare
| @@ -150,6 +156,52 @@ public static Builder constructorBuilder() { | |||
| return new Builder(CONSTRUCTOR); | |||
| } | |||
|
|
|||
| /** | |||
| * Create a builder which overrides the specified {@code method}. This will copy its visibility | |||
There was a problem hiding this comment.
nit: drop the specified. Using code font is good enough!
|
LGTM |
JakeWharton
force-pushed
the
jw/override
branch
from
561e389 to
1bf737d
Compare
JakeWharton
force-pushed
the
jw/override
branch
from
1bf737d to
cb2a6f4
Compare
JakeWharton
added a commit
that referenced
this pull request
Feb 19, 2015
MethodSpec factory for overriding an ExecutableElement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone know a good way to test this without writing a novel of mocking? I filed google/compile-testing#65 which seems like it would be a good approach.
Closes #228.