Upgraded the plugin so it works with AGP-8.x.x #254
Merged
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonjenniges hello, can u please review this PR . |
|
@shauna-kimura thanks for the approval, could u help me with the next step, i have already signed the cla. |
Armaxis
approved these changes
Jan 28, 2025
Armaxis
force-pushed
the
feature/upgrade-agp-8.6
branch
from
6ebd4ac to
5cb781c
Compare
|
|
Merged
|
@SSamratR We have released IAP SDK 1.7.10, the issues should now be resolved! Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses compatibility issues with the Square In-App Payments Flutter SDK on newer versions of Android Gradle Plugin (AGP) and updates the Java implementation to align with the latest Android development standards. Specifically, this PR:
Updates the compileSdk to 35 to ensure compatibility with the latest Android APIs.
Updates the Android Gradle Plugin to version 8.6.0 and JDK to version 17, ensuring compatibility with the latest build tools.
Refactors the CardEntryModule.java to correctly reference style resources, resolving runtime issues related to UI customization.
These updates collectively address and resolve issues #240, #251, and #252, improving the reliability and compatibility of the plugin with modern Android development environments.
Related Issues
Fix #240
Fix #251
Fix #252
Changelog
Android Compatibility:
Updated compileSdk to 35.
Updated AGP to 8.6.0.
Updated JDK to 17.
Java Refactor:
Modified CardEntryModule.java to correctly reference style resources, fixing crashes and inconsistencies in UI rendering.