Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix local tests #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

try to fix local tests #44

wants to merge 1 commit into from

Conversation

squangelo
Copy link
Collaborator

@squangelo squangelo commented Dec 4, 2024

Local tests fail on main:

============================================================================ short test summary info ============================================================================
FAILED tests/test_config.py::test_invalid_type_specified[cascade.yml] - Failed: DID NOT RAISE <class 'ValueError'>
FAILED tests/test_config.py::test_gcp_resource[cascade.yaml] - TypeError: 'NoneType' object is not subscriptable
FAILED tests/test_config.py::test_gcp_resource[cascade.yml] - FileExistsError: [Errno 17] File exists in the fake filesystem: '/cascade.yml'
FAILED tests/test_config.py::test_databricks_resource[cascade.yaml] - FileExistsError: [Errno 17] File exists in the fake filesystem: '/cascade.yaml'
FAILED tests/test_config.py::test_databricks_resource[cascade.yml] - FileExistsError: [Errno 17] File exists in the fake filesystem: '/cascade.yml'
FAILED tests/test_config.py::test_merged_resources[cascade.yaml] - FileExistsError: [Errno 17] File exists in the fake filesystem: '/cascade.yaml'
FAILED tests/test_config.py::test_merged_resources[cascade.yml] - FileExistsError: [Errno 17] File exists in the fake filesystem: '/cascade.yml'
FAILED tests/test_torch.py::test_torchjob - FileNotFoundError: https://storage.googleapis.com/upload/storage/v1/b/ds-cash-production-cascade/o
ERROR tests/test_config.py::test_invalid_type_specified[cascade.yaml] - AttributeError: torch._inductor.config.os does not exist

Haven't had time to dig much into it but it looks like it's due to different tests filesystem fixtures interacting with each other. After a letting goose got at it for a while I got it down to only error in test_torch.py:

============================================================================ short test summary info ============================================================================
FAILED tests/test_torch.py::test_torchjob - ModuleNotFoundError: No module named 'block_cascade.executors.vertex.executor.GcpExecutor'; 'block_cascade.executors.vertex.executor' is not a package
ERROR tests/test_vertex_executor.py::test_stage - OSError: could not create numbered dir with prefix pytest- in /var/folders/lt/6znk4r891xdcrhm2s2cjlzk40000gn/T/pytest-of-angelo after 10 tries
=============================================================== 1 failed, 35 passed, 3 warnings, 1 error in 5.72s ===============================================================

@squangelo squangelo requested a review from xmachak December 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant