fix sync 'could not get unknown property libs' in gradle-plugin #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #744 fixes #757 We had a symlink for `<root>/gradle-plugin/gradle` which pointed to `<root>/gradle`, so that we wouldn't have to maintain two versions of the wrapper files. That symlink apparently doesn't always work for the `libs.versions.toml` file. Instead, we can use the normal `from(file('../gradle/libs.version.toml'))` syntax for the catalog, and just symlink the `gradle/wrapper` directory instead.
vRallev
approved these changes
Oct 30, 2023
JoelWilcox
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #744
fixes #757
We had a symlink for
<root>/gradle-plugin/gradlewhich pointed to<root>/gradle, so that we wouldn't have to maintain two versions of the wrapper files. That symlink apparently doesn't always work for thelibs.versions.tomlfile.Instead, we can use the normal
from(file('../gradle/libs.version.toml'))syntax for the catalog, and just symlink thegradle/wrapperdirectory instead.