removing all hidden KSP logic #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
commented
Dec 6, 2024
| dependencyGuard.configuration("runtimeClasspath") | ||
|
|
||
| target.plugins.withJavaTestFixturesPlugin { | ||
| dependencyGuard.configuration("testFixturesRuntimeClasspath") |
There was a problem hiding this comment.
This corresponds to a published artifact, so we should be tracking its classpath like the others.
| com.google.dagger:dagger-compiler:2.52 | ||
| com.google.dagger:dagger-spi:2.52 | ||
| com.google.dagger:dagger:2.52 | ||
| com.google.devtools.ksp:symbol-processing-api:1.9.24-1.0.20 |
There was a problem hiding this comment.
By removing KSP from our own dependencies, we removed:
com.google.devtools.ksp:symbol-processing-aa-embeddable:2.0.0-1.0.22
com.google.devtools.ksp:symbol-processing-api:2.0.0-1.0.22
com.google.devtools.ksp:symbol-processing-common-deps:2.0.0-1.0.22
com.google.devtools.ksp:symbol-processing:2.0.0-1.0.22
com.squareup:kotlinpoet-ksp:1.18.1
dev.zacsweers.kctfork:ksp:0.5.1
This com.google.devtools.ksp:symbol-processing-api:1.9.24-1.0.20 dependency comes from the dagger-compiler dependency.
JoelWilcox
approved these changes
Dec 6, 2024
RBusarow
force-pushed
the
rick/remove-ksp
branch
from
19b57cb to
268bed9
Compare
RBusarow
force-pushed
the
rick/remove-ksp
branch
from
268bed9 to
9bdcfab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.