Couple comments for posterity

square · Nov 25, 2023 · 7b2ddf4 · 7b2ddf4
1 parent 50fc848
commit 7b2ddf4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/AssistedFactoryCodeGen.kt b/compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/AssistedFactoryCodeGen.kt
@@ -214,6 +214,7 @@ object AssistedFactoryCodeGen : AnvilApplicabilityChecker {
       // `clazz` must be first in the list because of `distinctBy { ... }`, which keeps the first
       // matched element. If the function's inherited, it can be overridden as well. Prioritizing
       // the version from the file we're parsing ensures the correct variance of the referenced types.
+      // TODO can't use getAllFunctions() yet due to https://github.com/google/ksp/issues/1619
       val assistedFunctions = sequenceOf(this)
         .plus(getAllSuperTypes().mapNotNull { it.resolveKSClassDeclaration() })
         .distinctBy { it.qualifiedName?.asString() }

diff --git a/compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/DaggerGenerationUtils.kt b/compiler/src/main/java/com/squareup/anvil/compiler/codegen/dagger/DaggerGenerationUtils.kt
@@ -239,7 +239,7 @@ private fun ClassReference.declaredMemberInjectParameters(
  * Base -> Middle -> Impl
  */
 internal fun KSClassDeclaration.memberInjectParameters(): List<MemberInjectParameter> {
-  // TODO can we use getAllProperties()?
+  // TODO can we use getAllProperties() after https://github.com/google/ksp/issues/1619?
   return sequenceOf(asType(emptyList()))
     .plus(getAllSuperTypes())
     .mapNotNull {