Restore swift 5 compilations #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lickel
commented
Sep 25, 2024
| @@ -418,33 +418,73 @@ private class DelegateThunk<FetchedObject: FetchableObject> { | |||
|
|
|||
| private weak var parent: (any Parent)? | |||
|
|
|||
| #if compiler(<6) | |||
| private let willChange: @MainActor (_ controller: Controller) -> Void | |||
There was a problem hiding this comment.
Marking these as @sendable in Swift 6 is awkward since it would require Parent to be sendable.
That's why I can't use the old Thunk impl in Swift 6
lickel
force-pushed
the
restore-swift5
branch
6 times, most recently
from
9f610e2
to
4c7fa22
Compare
lickel
force-pushed
the
restore-swift5
branch
from
4c7fa22
to
98fa76f
Compare
lickel
force-pushed
the
restore-swift5
branch
from
98fa76f
to
cae78a8
Compare
jgilbert002
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two main issues were:
KeyPath<> & SendableI mostly don't care about this except that older versions of SPM are getting very confused since the
swift-tools-versionwas too high