Add async operations and pagination completion #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattfaluotico
changed the title
mattfaluotico
force-pushed
the
mfaluotico/perform-async
branch
from
dc83ef5
to
fe9b299
Compare
lickel
reviewed
Apr 2, 2024
FetchRequests/Sources/Controller/FetchedResultsControllerProtocol.swift
Outdated
Show resolved
Hide resolved
lickel
reviewed
Apr 2, 2024
| performOnMainThread { | ||
| self?.manuallyInsert(objects: pageResults, emitChanges: true) | ||
| } | ||
|
|
||
| DispatchQueue.main.async { |
There was a problem hiding this comment.
Add comment along the lines of // force this to run on the _next_ run loop, at which point any debounced insertions should have happened
There was a problem hiding this comment.
And discussed offline that you could be cognizant of the debounced inserts flag and not use an async call if we're not debouncing.
mattfaluotico
force-pushed
the
mfaluotico/perform-async
branch
from
d5ad2cf
to
3ee6795
Compare
lickel
reviewed
Apr 3, 2024
| @@ -41,16 +41,29 @@ public class PaginatingFetchDefinition<FetchedObject: FetchableObject>: FetchDef | |||
| private extension InternalFetchResultsControllerProtocol { | |||
| @MainActor | |||
| func performPagination( | |||
| with paginationRequest: PaginatingFetchDefinition<FetchedObject>.PaginationRequest | |||
| with paginationRequest: PaginatingFetchDefinition<FetchedObject>.PaginationRequest, | |||
| debounceInsertsAndReloads: Bool, | |||
There was a problem hiding this comment.
- Nit:
willDebounceInsertsAndReloads
| with paginationRequest: PaginatingFetchDefinition<FetchedObject>.PaginationRequest | ||
| with paginationRequest: PaginatingFetchDefinition<FetchedObject>.PaginationRequest, | ||
| debounceInsertsAndReloads: Bool, | ||
| completion: @escaping (_ hasPageResults: Bool) -> Void |
| @@ -77,8 +90,21 @@ public class PaginatingFetchedResultsController< | |||
| } | |||
|
|
|||
| @MainActor | |||
| public func performPagination() { | |||
| performPagination(with: paginatingDefinition.paginationRequest) | |||
| public func performPagination(completion: @escaping (_ hasPageResults: Bool) -> Void = { _ in }) { | |||
lickel
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performPagination, informing consumers if the page request returned results.