Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'center' parameter to whether to center the tracking component. #178

Merged
merged 2 commits into from
Jan 8, 2024
Merged

New 'center' parameter to whether to center the tracking component. #178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e854da
New 'center' parameter to whether to center the trakcing component.
Jan 7, 2024
bc01903
Merge of documentation files about tracking component
Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions examples/official-site/sqlpage/migrations/32_tracking_update.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
INSERT INTO parameter (
component,
name,
description,
type,
top_level,
optional
)
VALUES (
'tracking',
'center',
'Whether to center the component.',
'BOOLEAN',
TRUE,
TRUE
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep that in the existing tracking component documentation file ?

The database behind sql.ophir.dev is in-memory anyway and migrations are reapplied on every deploy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will merge the two files :)

5 changes: 2 additions & 3 deletions sqlpage/templates/tracking.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="card my-2 col-md-{{default width 12}}">
<div class="card my-2 col-md-{{default width 12}}{{#if center}} mx-auto{{/if}}">
<div class="card-body">
<div class="d-flex align-items-center">
<div class="subheader">{{title}}</div>
Expand All @@ -23,5 +23,4 @@
</div>
</div>
</div>
</div>

</div>