Add tracking component #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 29, 2023 16:35
|
Divider component added |
lovasoa
requested changes
Dec 29, 2023
There was a problem hiding this comment.
Wow, these look great, thank you for the useful contribution !
Two small remarks:
- To make it as easy as possible to switch between components and to memorize properties, we try to reuse property names as much as possible between components. In that spirit, I think the
stateproperty of the tracking component should be namedcolorinstead. One can add an example with'danger' as colorto illustrate color name aliases. And maybe the tooltip should be namedtitle, for consistency. - The spacing and sizing inside the tracking card seems a little off to me, when compared to tabler's example :
- do you think we could make it a little more compact, and maybe make the text stand out more ?
- I think we should add a small vertical margin at the end of the component, as in other components. This looks more natural when used in combination with other components.
lovasoa
reviewed
Dec 29, 2023
lovasoa
reviewed
Dec 29, 2023
examples/official-site/sqlpage/migrations/28_tracking_component.sql
Outdated
Show resolved
Hide resolved
lovasoa
reviewed
Dec 29, 2023
…t.sql Co-authored-by: Ophir LOJKINE <[email protected]>
…, spacing between items)
lovasoa
reviewed
Dec 29, 2023
lovasoa
approved these changes
Dec 29, 2023
|
Thanks again for your contribution, @olivierauverlot ! PRs adding useful components are always welcome ! |
|
I'll try to make a new release soon that includes your work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the tracking component (https://tabler.io/docs/components/tracking)