Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constraint_name type in create_primary_key #1452

Closed
wants to merge 1 commit into from

Conversation

kasium
Copy link
Contributor

@kasium kasium commented Apr 4, 2024

The constraint name in create_primary_key should be optional, but for batch operations is is required according to the type annotations

Description

Changed the type annotation to Optional[str]

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@CaselIT
Copy link
Member

CaselIT commented Apr 4, 2024

Indeed, thanks for looking.

I'll update the stubs and commit

@CaselIT CaselIT requested a review from sqla-tester April 4, 2024 18:11
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 8afb2bf of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 8afb2bf: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5243

@kasium
Copy link
Contributor Author

kasium commented Apr 4, 2024

Thanks!

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5243 has been merged. Congratulations! :)

@kasium kasium deleted the patch-1 branch April 25, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants