Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] dist/sql-asm-memory-growth-debug.js build target support #330

Closed

Conversation

brody4hire
Copy link

@brody4hire brody4hire commented Jan 12, 2020

(updated)

  • add this debug target to Makefile
  • quick documentation in README.md
  • add sql-asm-memory-growth-debug to npm test

This PR is assuming that we do want to continue actively supporting the asm.js build targets and do not want to enable the memory growth in the existing dist/sql-asm-debug.js build target.

originally proposed as part of PR #319

@kaizhu256
Copy link
Member

should this be closed in favor of pr #431?

@brody4hire
Copy link
Author

I think so

@lovasoa lovasoa closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants