add ability to define the size of the database in the constructor

[missvalentinep]

When we have to work with big data, the ability to predefine the size of a new database can significantly speed up script execution time, because multiple calls to MEMF.expandFileStorage is way less efficient than one "bigger" call to it.

JavaScript profile of merging 7 databases (each of size ~15 MB) into one, without expanding the final db file first

The same operation but with expanding the final database to the size of (sum of 7 databases' sizes)

[miripiruni]

@lovasoa could you pay attention to this change please? This is not just optimization. initialDbSize allows us to merge several tables in a acceptable amount of time. The union is too slow without it.

Thank you!

[lovasoa]

The structure of this repo makes it very difficult to review changes. I am currently not merging pull requests by lack of time.
I cannot just merge this kind of PR because they contain a lot of minified JS that could contain malicious code.

One thing to do that would make it much easier to make changes is to handle compilation to JS by a continuous integration tool, and maybe use a more popular language such as JS of TypeScript.

[missvalentinep]

What if I removed the compiled files from pull request and you compiled them yourself or left the compilation to prepublish command?

[miripiruni]

@lovasoa OK, I totally agree. Internet is dangerous place.

To be sure there are no malware in minified JS: May I ask you to take diff from src/api.coffee only and make dist/* by yourself?

[miripiruni]

I cannot just merge this kind of PR because they contain a lot of minified JS that could contain malicious code.

The fact is we also are tremble because it's hard to understand that dist/* from latest version currently does not contains any suspicious code.

[lovasoa]

What would both reduce the maintenance burden (which is the biggest problem here) and improve security is having a continuous integration service bundling the files.

[lovasoa]

@kripken : maybe you can activate GitHub actions for this repo? https://github.com/features/actions

[kripken]

@lovasoa all I see is a way to request being added to the beta - is there something else? I did that now.

[lovasoa]

No, nothing else. Once you are added to the beta, we can add a yaml file in .github/workflows with the scripts we want to run.

[kripken]

I got an email that I am in the beta, so maybe it can work now...

[lovasoa]

Thank you Alon. I created a github workflow that compiles the code, tests it, and uploads the resulting artifacts: https://github.com/kripken/sql.js/actions