Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Bump version 1.0 #125

Merged
merged 4 commits into from
Jun 25, 2024
Merged

[cli] Bump version 1.0 #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9711be
Use AssemblyInformationalVersion as extractor version
albertospelta Jun 21, 2024
33f22d6
Add create release step in release-vpax-cli.yml
albertospelta Jun 21, 2024
8a1ee47
Fix publicReleaseRefSpec regex in version.json
albertospelta Jun 25, 2024
5719162
Bump version 1.0
albertospelta Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/release-vpax-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@ jobs:
path: src/${{ env.PROJECT }}
- name: dotnet pack
run: dotnet pack 'src/${{ env.PROJECT }}/${{ env.PROJECT }}.csproj' -c Release -o .
- shell: bash
name: nuget push
- name: nuget push
run: dotnet nuget push './${{ env.PROJECT }}.${{ steps.nbgv.outputs.NuGetPackageVersion }}.nupkg' -k "$NUGET_API_KEY" -s https://api.nuget.org/v3/index.json
env:
NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
- name: create release
run: |
PRERELEASE_FLAG=$([[ "${{ steps.nbgv.outputs.PrereleaseVersion }}" != "" ]] && echo "--prerelease" || echo "")
gh release create ${{ env.RELEASE_TAG }} --title ${{ env.RELEASE_TAG }} --target $GITHUB_SHA --generate-notes --draft $PRERELEASE_FLAG
env:
RELEASE_TAG: ${{ env.PROJECT }}_${{ steps.nbgv.outputs.NuGetPackageVersion }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion src/Dax.Vpax.CLI/Commands/ExportCommandHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
// TODO: forward cancellation token to vertipaq-analyzer extractor
var cancellationToken = context.GetCancellationToken();
var extractorAppName = ThisAssembly.AssemblyName;
var extractorAppVersion = ThisAssembly.AssemblyFileVersion;
var extractorAppVersion = ThisAssembly.AssemblyInformationalVersion;

var path = context.ParseResult.GetValueForArgument(PathArgument);
var connectionString = context.ParseResult.GetValueForArgument(ConnectionStringArgument);
Expand Down
4 changes: 2 additions & 2 deletions src/Dax.Vpax.CLI/version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "0.1-beta",
"version": "1.0",
"nugetPackageVersion": {
"semVer": 2
},
"publicReleaseRefSpec": [
"^refs/heads/master"
"^refs/heads/master$"
],
"pathFilters": [
"./"
Expand Down