Merge new User database model #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add check boxes to courses.html, implement participation certificate generator * return applicant mail if checkbox in course.html is marked * write logic for participation_cert pdf generation and implement zip-writer * nicer checkbox design * minor final changes
Switch to role based access system
urvdp
added a commit
that referenced
this pull request
Apr 12, 2024
* update excel templates * export for participation certificates (#16) * add check boxes to courses.html, implement participation certificate generator * return applicant mail if checkbox in course.html is marked * write logic for participation_cert pdf generation and implement zip-writer * nicer checkbox design * minor final changes * minor changes in spanish templates * bugfix on spanisch_hueber * give all users the possibility to generate participation certificates * Fix non-discounted price being shown in outstanding payments * Use roles to store user permissions * Add helper to check if user has superuser role * Rename LANGUAGE_ADMIN role to COURSE_ADMIN * Update can_edit_course check with new role system * Create log entries for courses, not for languages * Replace usages of user.languages * Add additional teacher attributes to user model --------- Co-authored-by: Tobias Dierich <[email protected]>
urvdp
added a commit
that referenced
this pull request
Apr 29, 2024
* update excel templates * export for participation certificates (#16) * add check boxes to courses.html, implement participation certificate generator * return applicant mail if checkbox in course.html is marked * write logic for participation_cert pdf generation and implement zip-writer * nicer checkbox design * minor final changes * minor changes in spanish templates * bugfix on spanisch_hueber * give all users the possibility to generate participation certificates * Fix non-discounted price being shown in outstanding payments * Use roles to store user permissions * Add helper to check if user has superuser role * Rename LANGUAGE_ADMIN role to COURSE_ADMIN * Update can_edit_course check with new role system * Create log entries for courses, not for languages * Replace usages of user.languages * Add additional teacher attributes to user model --------- Co-authored-by: Tobias Dierich <[email protected]>
urvdp
added a commit
that referenced
this pull request
May 13, 2024
* solve merge conflicts manually * create language page for adding teachers * fix merge conflicts in views * resolve rebase conflict in views * begin to implement pages to add and administrate teachers * finish add form for teachers, add multiple course select field to cached * add basic db.model for teacher * add edit_teacher view, finish add_teacher function, implement list to show all teachers of one language, finish db.Model Teacher * implement logic to add/remove courses to teachers, delete Teacher attribute languages (implicit known through link between courses and languages -> be efficient), course is only addable to a teacher, if it is not assigned already * put administration view functions in admin_views (own package), code view for teachers to manage their courses (def teacher in views) * add attendance base view and view to put the grade * add grade edit views and intern representation for the grade * changes to insert grades (at the moment not fully working) * export for participation certificates (#16) * add check boxes to courses.html, implement participation certificate generator * return applicant mail if checkbox in course.html is marked * write logic for participation_cert pdf generation and implement zip-writer * nicer checkbox design * minor final changes * add teacher administration view * Merge new User database model (#18) * update excel templates * export for participation certificates (#16) * add check boxes to courses.html, implement participation certificate generator * return applicant mail if checkbox in course.html is marked * write logic for participation_cert pdf generation and implement zip-writer * nicer checkbox design * minor final changes * minor changes in spanish templates * bugfix on spanisch_hueber * give all users the possibility to generate participation certificates * Fix non-discounted price being shown in outstanding payments * Use roles to store user permissions * Add helper to check if user has superuser role * Rename LANGUAGE_ADMIN role to COURSE_ADMIN * Update can_edit_course check with new role system * Create log entries for courses, not for languages * Replace usages of user.languages * Add additional teacher attributes to user model --------- Co-authored-by: Tobias Dierich <[email protected]> * implementation of new database model for teacher administration views * finish integration of database model, adapt edit_teacher with add/remove course * prefill edit grade field and show corresponding field in template * show statistics for teacher administration, code attendance table * adjust design and spacing of attendance table * attempt using Flask WTForms for the input handling of the grade (edit_grade.html). Unfortunately the FieldList with FormField causes problems e g Field Validation seems not to work, flashed messages not displayed,... * implement edit_grade form to adjust ects points for each student and set the grade in percentages, later it is shown as grade with comma * add hide_grade template * finish implementation of the templates for setting the grade, ects and if the grade should be hidden * fix logic error in edit_grade * adapt model to new database role * send pw reset mails to teachers, display teachers in course template, begin to limit views for teachers * show courses that are not assigned to a teacher in teacher overview * fix course assigning to teachers, make error messages work as intended * show only avalable courses in add_teacher form * restrict access for teachers to only necessary pages * integrate edit grade flow into language table of courses as own column * fix grade routing for admins, add page for teachers without any course to make new course assignments possible * fix teacher routing, remove complete row in database when removing course role, fix check availability function to assign new courses to a teacher * minor view enhancements --------- Co-authored-by: Tobias Dierich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.