Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix numericInput_dsfr #156

Merged
merged 1 commit into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: shinygouv
Title: Implement the DSFR for your shiny applications
Version: 1.0.3
Version: 1.0.4
Authors@R: c(
person("Juliette", "ENGELAERE-LEFEBVRE", , "[email protected]", role = c("aut", "cre")),
person("Sébastien", "Rochette", , "[email protected]", role = "aut",
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# shinygouv 1.0.4

## Fix

* numericInput_dsfr : correction du template qui ne fonctionnait plus avec shiny v1.8.1

# shinygouv 1.0.3

## Fix
Expand Down
3 changes: 1 addition & 2 deletions R/numericinput_dsfr.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
#'
#' ui <- fluidPage_dsfr(
#' header = header_dsfr(
#' intitule = "Intitule",
#' officiel = "Officiel",
#' intitule = c("Intitule", "officiel"),
#' nom_site_service = "Nom du site / service",
#' baseline = "baseline - precisions sur l organisation",
#' class = "fr-m-1w"
Expand Down
3 changes: 1 addition & 2 deletions R/updatenumericinput_dsfr.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
#'
#' ui <- fluidPage_dsfr(
#' header = header_dsfr(
#' intitule = "Intitule",
#' officiel = "Officiel",
#' intitule = c("Intitule", "Officiel"),
#' nom_site_service = "Nom du site / service",
#' baseline = "baseline - precisions sur l organisation",
#' class = "fr-m-1w"
Expand Down
6 changes: 2 additions & 4 deletions dev/flat_composants/flat_numericInput.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,7 @@ if (interactive()) {

ui <- fluidPage_dsfr(
header = header_dsfr(
intitule = "Intitule",
officiel = "Officiel",
intitule = c("Intitule", "officiel"),
nom_site_service = "Nom du site / service",
baseline = "baseline - precisions sur l organisation",
class = "fr-m-1w"
Expand Down Expand Up @@ -386,8 +385,7 @@ if (interactive()) {

ui <- fluidPage_dsfr(
header = header_dsfr(
intitule = "Intitule",
officiel = "Officiel",
intitule = c("Intitule", "Officiel"),
nom_site_service = "Nom du site / service",
baseline = "baseline - precisions sur l organisation",
class = "fr-m-1w"
Expand Down
2 changes: 1 addition & 1 deletion inst/v1.9.3/composant/numericinput.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<label class="fr-label" id="{{inputId}}-label" for="{{inputId}}">
{{label}}
</label>
<input id="{{inputId}}" value="{{value}}" min="{{min}}" max="{{max}}" step="{{step}}" class="fr-input shiny-bound-input" pattern="[0-9]*" inputmode="numeric" type="number" name="text-input-number">
<input id="{{inputId}}" value="{{value}}" min="{{min}}" max="{{max}}" step="{{step}}" class="fr-input shiny-input-number" pattern="[0-9]*" inputmode="numeric" type="number" name="text-input-number">
</div>
3 changes: 1 addition & 2 deletions man/numericInput_dsfr.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions man/updateNumericInput_dsfr.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified tests/testthat/snapshot/numericInput_dsfr.Rda
Binary file not shown.
Binary file modified tests/testthat/snapshot/numericInput_dsfr_template.Rda
Binary file not shown.
Loading