Merge pull request #156 from spyrales/155-bug_numericinput_dsfr

bug fix numericInput_dsfr
spyrales · Jul 26, 2024 · 2b9e653 · 2b9e653
2 parents ba026ff + ab8b69c
commit 2b9e653
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: shinygouv
 Title: Implement the DSFR for your shiny applications
-Version: 1.0.3
+Version: 1.0.4
 Authors@R: c(
     person("Juliette", "ENGELAERE-LEFEBVRE", , "[email protected]", role = c("aut", "cre")),
     person("Sébastien", "Rochette", , "[email protected]", role = "aut",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,9 @@
+# shinygouv 1.0.4
+
+## Fix 
+
+* numericInput_dsfr : correction du template qui ne fonctionnait plus avec shiny v1.8.1
+
 # shinygouv 1.0.3
 
 ## Fix 

diff --git a/R/numericinput_dsfr.R b/R/numericinput_dsfr.R
@@ -22,8 +22,7 @@
 #'
 #'   ui <- fluidPage_dsfr(
 #'     header = header_dsfr(
-#'       intitule = "Intitule",
-#'       officiel = "Officiel",
+#'       intitule = c("Intitule", "officiel"),
 #'       nom_site_service = "Nom du site / service",
 #'       baseline = "baseline - precisions sur l organisation",
 #'       class = "fr-m-1w"

diff --git a/R/updatenumericinput_dsfr.R b/R/updatenumericinput_dsfr.R
@@ -22,8 +22,7 @@
 #'
 #'   ui <- fluidPage_dsfr(
 #'     header = header_dsfr(
-#'       intitule = "Intitule",
-#'       officiel = "Officiel",
+#'       intitule = c("Intitule", "Officiel"),
 #'       nom_site_service = "Nom du site / service",
 #'       baseline = "baseline - precisions sur l organisation",
 #'       class = "fr-m-1w"

diff --git a/dev/flat_composants/flat_numericInput.Rmd b/dev/flat_composants/flat_numericInput.Rmd
@@ -201,8 +201,7 @@ if (interactive()) {
 
   ui <- fluidPage_dsfr(
     header = header_dsfr(
-      intitule = "Intitule",
-      officiel = "Officiel",
+      intitule = c("Intitule", "officiel"),
       nom_site_service = "Nom du site / service",
       baseline = "baseline - precisions sur l organisation",
       class = "fr-m-1w"
@@ -386,8 +385,7 @@ if (interactive()) {
 
   ui <- fluidPage_dsfr(
     header = header_dsfr(
-      intitule = "Intitule",
-      officiel = "Officiel",
+      intitule = c("Intitule", "Officiel"),
       nom_site_service = "Nom du site / service",
       baseline = "baseline - precisions sur l organisation",
       class = "fr-m-1w"

diff --git a/inst/v1.9.3/composant/numericinput.html b/inst/v1.9.3/composant/numericinput.html
@@ -2,5 +2,5 @@
   <label class="fr-label" id="{{inputId}}-label" for="{{inputId}}">
     {{label}}
   </label>
-  <input  id="{{inputId}}" value="{{value}}" min="{{min}}" max="{{max}}" step="{{step}}" class="fr-input shiny-bound-input" pattern="[0-9]*" inputmode="numeric" type="number" name="text-input-number">
+  <input  id="{{inputId}}" value="{{value}}" min="{{min}}" max="{{max}}" step="{{step}}" class="fr-input shiny-input-number" pattern="[0-9]*" inputmode="numeric" type="number" name="text-input-number">
 </div>
diff --git a/man/numericInput_dsfr.Rd b/man/numericInput_dsfr.Rd
diff --git a/man/updateNumericInput_dsfr.Rd b/man/updateNumericInput_dsfr.Rd
diff --git a/tests/testthat/snapshot/numericInput_dsfr.Rda b/tests/testthat/snapshot/numericInput_dsfr.Rda
diff --git a/tests/testthat/snapshot/numericInput_dsfr_template.Rda b/tests/testthat/snapshot/numericInput_dsfr_template.Rda