Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jpackage error for Java 9 and later #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Searen1984
Copy link

#16

Fixed by introducing two profiles with different dependencies.

  1. Profile: Activated by default and has a dependency to the old joou-java-6 which should be used up to and including Java 8
  2. Profile: Activated if Java 9 or later is detected as build environment (by using JAVA_HOME environment variable) and has as dependency joou which should be used for Java 9 or later

Using jpackage lead to an error because there was a dependency to joou-java-6. By introducing two profiles this issue could be solved. The correct profile is activated based on the Java environment (defined through the JAVA_HOME environment variable). For Java 9 and later joou for Java 9 and later is used while for Java 8 and earlier joou-java-6 is used as dependency. Tested with Java 8 and Java 11
Fixed jpackage issue using joou for Java 9+
If Java 9 or later is not used as profile it is the default profile which uses joou-java-6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant