Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly sort SD-JWT concealing JSON pointers. #614

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Correctly sort SD-JWT concealing JSON pointers. #614

merged 1 commit into from
Sep 17, 2024

Conversation

timothee-haudebourg
Copy link
Contributor

I spotted a mistake in SdJwtPayload::conceal_claims where I sort JSON pointers to conceal claims in the correct order, but never use the sorted_pointers array I create.

@timothee-haudebourg timothee-haudebourg mentioned this pull request Sep 17, 2024
Merged
@Ryanmtate Ryanmtate merged commit 868e073 into main Sep 17, 2024
4 checks passed
@Ryanmtate Ryanmtate deleted the fix-sd-jwt-pointer-order branch September 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryanmtate Ryanmtate Ryanmtate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothee-haudebourg @Ryanmtate