-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bitstring Status List implementation. #609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions (mostly around the changes in spec & whether there are ways to mitigate some of the more problematic changes), but otherwise the changes themselves look generally good to me!
crates/status/src/impl/bitstring_status_list/syntax/entry_set/mod.rs
Outdated
Show resolved
Hide resolved
e488a9b
to
e5abf36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed with Timothée. Leaving the common interfaces as is for now as they are helpful for testing, and since the spec is not fully finalized yet anyways. Once it settles, the interface should be reworked in case there's a cleaner, more useful abstraction.
This PR updates the Bitstring Status List implementation to the Candidate Recommendation Draft 10 June 2024. The current implementation is based on the Working Draft 6 April 2024.
In this new version, the
statusSize
,statusMessage
andstatusReference
properties have been moved fromBitstringStatusList
toBitstringStatusListEntry
. This has implications in the rest of thessi-status
crate. Because the status size is not stored in the list but in each entry, this changes the common API shared withTokenStatusList
(defined incrates/status/src/impl/any.rs
) so that a status size can be optionally passed to the access functions.To accomodate status list construction I added the
SizedBitString
andSizedStatusList
types that also store the status size.There is still one small uncertainy about the new spec version because the old
BitstringStatusList
properties are still beeing referenced in one paragraph, but I think that's a mistake. Just to be sure I notified thevc-bitstring-status-list
repo: w3c/vc-bitstring-status-list#175Other changes
ssi-jws/secp256r1
for thessi-status
examples so that its able to verify the P-256 signatures given as samples.status_list_revocable_*.jsonld
sample files so the example client can verify them correctly.