Fully specializable credentials. #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
+1 to using full names for generic parameters instead of one-letter names 😬
Overall, I don't feel strongly about it -- but I do agree that only having subject being specialised is a bit odd. In my opinion, with this, the main and potentially only benefit is the (de)serialisation aspect, which saves a few lines of code for consumers -- but maybe I'm missing some use-cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SpecializedJsonCredentialtype allows an application to define a new credential type by customizing the input type parameters. However for now only the credential subject type, context and type can be customized, whereas some applications may want to customize others components like the credential status type.This PR adds all the credential components as parameters to the
SpecializedJsonCredentialtype, with defaults matching the current type for each component (so it does not impact existing code).