Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token_status_list::StatusSize deserializer. #568

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Fix token_status_list::StatusSize deserializer. #568

merged 3 commits into from
Jul 3, 2024

Conversation

timothee-haudebourg
Copy link
Contributor

Deserializing a status size fails because the JSON deserializer does not follow hints. This fixes the issue by calling u8::deserialize instead.

@timothee-haudebourg timothee-haudebourg self-assigned this Jul 3, 2024
eelanagaraj
eelanagaraj reviewed Jul 3, 2024
View reviewed changes
Copy link

@eelanagaraj eelanagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- wdyt about adding the following two cases too?

  • deserializing an entire string -> JsonStatus
  • deserialization case that should fail (i.e. number is > u8::MAX)

eelanagaraj
eelanagaraj approved these changes Jul 3, 2024
View reviewed changes
Copy link

@eelanagaraj eelanagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timothee-haudebourg timothee-haudebourg merged commit 157fb00 into main Jul 3, 2024
4 checks passed
@timothee-haudebourg timothee-haudebourg deleted the fix-status-size-deserializer branch July 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eelanagaraj eelanagaraj eelanagaraj approved these changes

Assignees

@timothee-haudebourg timothee-haudebourg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothee-haudebourg @eelanagaraj