Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer OUT_DIR for outputting the multicodec table #558

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ivan770
Copy link
Contributor

@ivan770 ivan770 commented Jun 28, 2024

Some Rust build environments (e.g. Crane) rely on build scripts using only OUT_DIR directory for producing build-time artifacts, erroring out otherwise.

This PR fixes the ssi-multicodec build failure in such cases.

Copy link
Contributor

@timothee-haudebourg timothee-haudebourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@timothee-haudebourg timothee-haudebourg merged commit 10deab4 into spruceid:main Jul 2, 2024
4 checks passed
@ivan770 ivan770 deleted the multicodec-out-dir branch July 2, 2024 13:16
@ivan770 ivan770 restored the multicodec-out-dir branch July 2, 2024 13:16
@ivan770 ivan770 deleted the multicodec-out-dir branch July 2, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants