Token Status List & Bitstring Status List v1.0 #551
Conversation
There was a problem hiding this comment.
I think it generally looks good (caveat: I don't have a lot of context on the jws & jwt/src changes).
In addition to the other comments, for the IETF status list, it'd be nice to have an enum for the standard status types (VALID, INVALID, SUSPENDED) but that doesn't need to be part of this PR.
crates/claims/crates/status/src/impl/bitstream_status_list/mod.rs
Outdated
Show resolved
Hide resolved
timothee-haudebourg
force-pushed
the
skit-183-implement-revocation-for-w3c-vcs
branch
from
165c789
to
ced1def
Compare
Also fix clippy warnings.
I've added const definitions for those standard token status values. |
| use super::{MaybeCached, ProviderError, StatusMapProvider, TypedStatusMapProvider}; | ||
|
|
||
| pub struct HttpClient<V> { | ||
| client: reqwest::Client, |
There was a problem hiding this comment.
I'm fine with using reqwest directly for the time being, but in the future we should use a trait similar to what openidconnect does https://docs.rs/openidconnect/4.0.0-alpha.2/openidconnect/trait.AsyncHttpClient.html
| } | ||
|
|
||
| pub trait TypedStatusMapProvider<I: ?Sized, T: EncodedStatusMap> { | ||
| #[allow(async_fn_in_trait)] |
There was a problem hiding this comment.
This is safe because id isn't Sized?
There was a problem hiding this comment.
Its always safe. Are you talking about the allow? It's just because the compiler like to warn us that users can't put bounds on the return type of those functions. But we don't care here.
timothee-haudebourg
deleted the
skit-183-implement-revocation-for-w3c-vcs
branch
This PR implements IETF Token Status List and W3C Bitstring Status List v1.0.