Data Integrity bbs-2023 Cryptosuite
#550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothee-haudebourg
changed the base branch from
treeldr
to
wall-184-osl-a-ssi-implement-vcdm-v2
timothee-haudebourg
force-pushed
the
wall-184-osl-a-ssi-implement-vcdm-v2
branch
from
3de118d
to
86ba42b
Compare
timothee-haudebourg
force-pushed
the
bbs-2023
branch
from
a64ee50
to
d18601b
Compare
timothee-haudebourg
force-pushed
the
wall-184-osl-a-ssi-implement-vcdm-v2
branch
2 times, most recently
from
c33c39f
to
ddcf958
Compare
timothee-haudebourg
force-pushed
the
bbs-2023
branch
from
d18601b
to
d760bd6
Compare
sbihel
reviewed
Jul 6, 2024
There was a problem hiding this comment.
I have not added Bbs2023 to the AnySuite enum, as there is no generic interface for Data-Integrity selective disclosure suites yet.
Do you plan to do it in this PR?
Otherwise, something funky happened with Github automatic replacement of the base branch. You might need to re-open the PR because the branch itself looks good, and this is too messy to be reviewed
crates/dids/methods/key/src/lib.rs
Outdated
| ssi_multicodec::ED25519_PUB, | ||
| ¶ms.public_key.0, | ||
| ) | ||
| .into_bytes(), | ||
| ), | ||
| "Bls12381G2" => multibase::encode( |
There was a problem hiding this comment.
In hindsight, Bls12381G2 should be of key type EC because it uses x,y,d coordinates. Maybe this is relevant:
timothee-haudebourg
force-pushed
the
bbs-2023
branch
from
52498cb
to
9ba677d
Compare
Now testing...
Unification of the signature options and verification options interface.
…o SD suites. Add `DataIntegrity::select` method.
timothee-haudebourg
force-pushed
the
bbs-2023
branch
from
9ba677d
to
8ddd4d6
Compare
|
I've added a let derived_vc = vc.select(params, options).await?; |
sbihel
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
bbs-2023cryptosuite defined by Data Integrity BBS Cryptosuites v1.0. It is implemented through theBbs2023type inssi-data-integrity-suiteslibrary. Thebbsfeature must be enabled.This is based on the
zkryptiumlibrary providing a Rust implementation of the BBS Signature Scheme. Only thebaselinefeature option is supported for now. Other options seem not stabilized yet and use features outside of the BBS Signature Scheme not provided byzkryptium. Other implementations such as Digital Bazaar's only provide the baseline option as well.I have not addedBbs2023to theAnySuiteenum, as there is no generic interface for Data-Integrity selective disclosure suites yet.