Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(did-key): Add EBSI Natural Person Format #545

Closed

Conversation

ianhamilton87
Copy link
Contributor

@ianhamilton87 ianhamilton87 commented Apr 2, 2024

Enhance did:key resolution to also be able to resolve

See: https://hub.ebsi.eu/vc-framework/did/natural-person
(But know that EBSI likes to move around their documentation and break links from time to time, so if this doesn't resolve in the future, search for EBSI natural person did:key)

implement from_multicodec for jwk_jcs_pub multicodec.
Also needed to promote serde_json from a dev-dependency to a regular dependency.

Relevant issues that are related to this PR:
w3c-ccg/did-method-key#63
#536

Ian Hamilton added 3 commits February 2, 2024 11:52
 implement from_multicodec for jwk_jcs_pub multicodec.
 Also needed to promote serde_json from a dev-dependency to a regular dependency.
 implement from_multicodec for jwk_jcs_pub multicodec.
 Also needed to promote serde_json from a dev-dependency to a regular dependency.
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ timothee-haudebourg
✅ mrappard
✅ ivan770
✅ rschulman
❌ Ian Hamilton


Ian Hamilton seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Update rust version due to failure in `Test WASM compilation`
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: "1.73.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one and only true change in this file - upped the toolchain to 1.73.0

@sbihel
Copy link
Member

sbihel commented Apr 22, 2024

Thank you for the PR, for the time being we'll mark it as blocked by #508.

@ianhamilton87 ianhamilton87 mentioned this pull request May 8, 2024
58 tasks
timothee-haudebourg and others added 18 commits June 20, 2024 17:40
Spanning VCs, DIDs, VMs, and more.
* Add `ssi-status` library implementing IETF and W3C bitvec status lists.
* Remove the `Verifiable` type.

* Simplify signature/verification environment using latest `json-ld`.
* Data Model v2.0 traits.
* VCDM v2.0 (JSON) syntax types.
* Add `DataIntegrityDocument` type.
* Add documentation, defaults & re-exports.
Also:
* Make present example compile, and add the scenarios as tests
Also:
- add end-to-end test for signing a `Ed25519Signature2020` VCDM v1 credential
- tweak `AddProofContext` to append contexts instead of replacing
Add `Context::contains` method.
Add `Context::iter` method.
Add `Context::insert` method.
Impl `IntoIterator` for `&Context`.
Impl `IntoIterator`for `Context`.
Impl `Extend` for `Context`.
Impl `From<Context>` for `json_ld::Context`.
Impl `TryFrom<json_ld::Context>` for `Context`.
Evidence is uncountable
* Merge `context` and `verifier`.
* Rename `with_default_options` into `into_vm_resolver`.
* Rename `Validate` into `ValidateClaims` trait.
* Rename `*Environment` traits into `*Provider` traits.
* Add `ResolverProvider` trait.
* Rename `Verifier` type into `VerificationParameters`.
* Add dedicated `verify` methods for secured claims types (`CompactJWS`, `DecodedJWS` and `DataIntegrity`).
* Optional date time parameter in `VerificationParameters`.
* Add documentation.
Set default VCDM v1 credential subject to `Object`.
Set default VCDM v2 credential subject to `NonEmptyObject`.
timothee-haudebourg and others added 21 commits July 3, 2024 16:13
* Move and re-export `ssi-status`.
* Make the `ssi-security::multibase` module public.
* Add `ecdsa-rdfc-2019` implementation.
* Update `credentials/v2` context.
* Fix tests.
* Remove debug print.
* Add e2e tests for ecdsa
* Fix `Multikey` to accept any algorithm, not just `EdDSA`.
* Fix features.
Co-authored-by: Simon Bihel <[email protected]>
…573)

* Remove `BitstringStatusListType`.
* Remove `BitstringStatusListEntryType`.
* Make `BitstringStatusListEntry` fields public.
* Add constructor for `BitstringStatusListEntry`.
* Add constructors and accessors for `bitstring_status_list::StatusPurpose`.
* Impl `Display` for `bitstring_status_list::StatusPurpose`.
* Add a few JSON-LD expansion tests.
---------
Co-authored-by: Timothée Haudebourg <[email protected]>
* Add bbs2023 suite.
* Factorize tests, ensure JSON canonicalization.
* Upgrade `uuid`to 1.9
* Lazy `Multikey` decoding.
* Unification of the signature options and verification options interface.
* Add `SelectiveCryptographicSuite` trait, providing a nice interface to SD suites.
* Add `DataIntegrity::select` method.
* Add `Bbs2023` variant to `AnySuite`.
* Upgrade `json-ld` to version 0.21.1.
* Remove feature gates on `Multikey`.

---------

Co-authored-by: Simon Bihel <[email protected]>
* Bring `eddsa-2022` back for back-compatibility.
* Fix sd dataset canonicalization
…o did-876-did-key-ebsi-format

# Conflicts:
#	.github/workflows/build.yml
#	crates/jwk/src/lib.rs
#	did-key/src/lib.rs
#	ssi-jwk/src/multicodec.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants