Update RustCrypto/signature crates #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| async-trait = "0.1" | ||
| thiserror = "1.0" | ||
| multibase = "0.8" | ||
| k256 = { version = "0.11", optional = true, features = ["ecdsa"] } | ||
| p256 = { version = "0.11", optional = true, features = ["ecdsa"] } | ||
| k256 = { version = "0.13.1", optional = true, features = ["ecdsa"] } |
There was a problem hiding this comment.
Do we want to pin to a specific minor version? I would think that with something like RustCrypto that actually follows semver that we'd want the minor field to float in case they find some bug that doesn't require an API change.
If we're willing to take the extra maintenance burden in exchange for a more curated set of dependencies, I'm down for that. I just want to make sure that's the trade off we explicitly want to make.
There was a problem hiding this comment.
I usually always specify minor and patch, with tools like dependabot I think it's not that much work for better stability. But in this case, being v0, the minor is actually the major
Mostly to upgrade ed25519-dalek which has a vulnerability. The impact should be minimal, but does include empty error messages when recovered addresses don't match. This was to avoid breaking changes, and it should be addressed after the upcoming major refactor.
sbihel
force-pushed
the
fix/update-rustcrypto
branch
from
feb71c9
to
909c7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to upgrade ed25519-dalek which has a vulnerability.
The impact should be minimal, but does include empty error messages when recovered addresses don't match. This was to avoid breaking changes, and it should be addressed after the upcoming major refactor.