Allow resolving did:webs with ports #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This is already done, and I've already got two other PRs merged here! (https://github.com/spruceid/ssi/pulls?q=is%3Apr+author%3ATaylorBeeston+is%3Aclosed) (see #442 (comment)) |
|
Thank you for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago, while maintaining the fork for LEF, I noticed that did:web's with ports currently aren't being resolved! The spec states to percent encode the colon as %3A for ports, so I added that in!
This is particularly useful when hosting dids locally and trying to resolve a
did:web:localhost%3A3000did during development. I also accounted for this by adjusting the http check fromdomain_name == "localhost"todomain_name.starts_with("localhost"), thereby allowing the domainlocalhost%3A3000to still use http rather than https.