Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sd-jwt to credential pack #42

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

Ryanmtate
Copy link
Contributor

This PR adds support for SD-JWT credentials in credential pack.

Other changes include some minor swiftformat changes.

We may wish to add swiftformat to the CI to ensure the code is checked before merge: CC @sbihel

@Ryanmtate
Copy link
Contributor Author

Ryanmtate commented Oct 16, 2024

NOTE: CI is failing given the need to update the release version for mobile-sdk-rs

Currently using this on a local build, moving this PR to draft as a result.

This PR is now using the latest mobile-sdk-rs v0.2.1

@Ryanmtate Ryanmtate marked this pull request as draft October 16, 2024 15:54
@sbihel
Copy link
Member

sbihel commented Oct 16, 2024

We may wish to add swiftformat to the CI to ensure the code is checked before merge: CC @sbihel

We're not using swiftformat currently, but we can consider replacing swiftlint (because of their overlap it's hard to use both)

@Ryanmtate Ryanmtate force-pushed the feat/add-sd-jwt-credential-pack branch from 5b313d5 to de20299 Compare October 22, 2024 22:43
@Ryanmtate Ryanmtate marked this pull request as ready for review October 22, 2024 22:44
@Ryanmtate Ryanmtate force-pushed the feat/add-sd-jwt-credential-pack branch from e241038 to 10c4b1b Compare October 23, 2024 00:07
@Juliano1612 Juliano1612 merged commit 1f1e330 into main Oct 23, 2024
1 check passed
@Juliano1612 Juliano1612 deleted the feat/add-sd-jwt-credential-pack branch October 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants