Constrain signature to bytes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2022
chunningham
approved these changes
Mar 29, 2022
| @@ -87,10 +87,23 @@ pub enum VerificationError { | |||
| NotCurrentlyValid, | |||
| } | |||
|
|
|||
| pub struct BasicSignature<S> { | |||
| pub struct BasicSignature<S: AsRef<[u8]> + TryFrom<Vec<u8>>> { | |||
There was a problem hiding this comment.
Makes sense according to the spec 👍, I would prefer to avoid the S :DagCbor bound in #7, but its not possible I think :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for spruceid/cacao-zcap#1 to be able to (de)serialize a signature of an arbitrary CACAO.
There's some overlap with this and #7 (which constrains the signature to be DagCbor encodable/decodable).