-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(overrides): Refactor service overrides to allow for more complexity #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollieread
added
type: refactor
Refactoring of code
status: accepted
The issue has been accepted/acknowledged and is being actioned or will be
labels
Jan 11, 2025
…supports nested directories
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=============================================
+ Coverage 68.49% 83.08% +14.59%
- Complexity 507 553 +46
=============================================
Files 68 73 +5
Lines 1441 1555 +114
=============================================
+ Hits 987 1292 +305
+ Misses 454 263 -191 ☔ View full report in Codecov by Sentry. |
…ion identity resolver tests
The sprout driver for the cache manager wasn't added if the cache manager had already been resolved, and because the driver creation method was bound to the manager, it wasn't able to access $this->drivers
The sprout driver for the cache manager wasn't added if the cache manager had already been resolved, and because the driver creation method was bound to the manager, it wasn't able to access $this->drivers
…e tenancy and/or tenant changes
…an existing original
…ated Laravel core
…essionHandler::performInsert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: accepted
The issue has been accepted/acknowledged and is being actioned or will be
type: refactor
Refactoring of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current service override functionality with the following key changes.
ServiceOverrideManager
that is responsible for registering, booting and all other service override actionsDeferrableServiceOverride
interface and functionality to support deferring service overridesServiceOverride
implementationsconfig/sprout/overrides.php
) to allow for more fine-grained complex config per service overrideoverride
tenancy option to provide a filtered list of overrides that are enabled for the tenancyoverride.all
tenancy option to enable all configured overridesconfig/sprout.php
toconfig/sprout/core.php