[FEATURE]: Auto Doc | Generate PDF from Template #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add open scd event
…ge inside plugins
…dependent-plugin-packages
| }); | ||
| function getValueFromNestedProperty(publisher: MessagePublisher, key: keyof MessagePublisherFilter): string { | ||
| const keyMap: Partial<Record<keyof MessagePublisherFilter, string>> = { | ||
| LogicalNodeIEDName: "logicalNodeInofrmation.IEDName", |
There was a problem hiding this comment.
I noticed a typo here Information
There was a problem hiding this comment.
uh nice spotting. Will rectify it
There was a problem hiding this comment.
Oups, your linter has gone wild !
This file is out of scope ;P
There was a problem hiding this comment.
Mhm maybe because in the beginning I check to see how documentation plugin was handling the pdf generation, I don't recall changing anything in the file though
Comment on lines
15
to
46
| let y = 10; | ||
| const pageHeight = doc.internal.pageSize.height; | ||
| const pageSize = doc.internal.pageSize; | ||
| const pageWidth = pageSize.width ? pageSize.width : pageSize.getWidth() | ||
| const marginBottom = 10; | ||
|
|
||
| const blockHandler: Record<ElementType, (block: Element) => void> = { | ||
| text: handleTextBlock, | ||
| image: () => {}, | ||
| signalList: processSignalListForPdfGeneration | ||
| } | ||
|
|
||
| function incrementYPositionForNextLine() { | ||
| y+=7; | ||
| } | ||
|
|
||
| function contentExceedsCurrentPage(y: number,pageHeight: number,marginBottom: number) { | ||
| return (y+10) > (pageHeight-marginBottom); | ||
| } | ||
|
|
||
| function handleTextBlock(block: Element){ | ||
| const wrappedText : string [] = doc.splitTextToSize(block.textContent ?? "", pageWidth-35); | ||
| for(const line of wrappedText){ | ||
| if (contentExceedsCurrentPage(y, pageHeight, marginBottom)) { | ||
| doc.addPage(); | ||
| y = 10; | ||
| } | ||
| doc.text(line, 10, y); | ||
| incrementYPositionForNextLine(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
There is a lot of magic number here, will we be able to understand them in the future ?
There was a problem hiding this comment.
The docs explain it, but I think I can improve on it by using explanatory variables
added 12 commits
February 18, 2025 13:27
michelguerin
approved these changes
Feb 19, 2025
salvar3nga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒 Description
When the signal list block element is selected, a pdf is generated based on the rows selected.
In the background signalLists are filtered and prepared for such pdf generation
📷 Demo screen recording or Screenshots
📋 Checklist
You may remove tasks that do not make sense in this PR.
🔦 Useful commits
You can add specific commits which are worth taking a look into