Feat/baylabels #242
Merged
Feat/baylabels #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/src/use-cases/uc-communication-information.ts # packages/uilib/src/lib/components/diagram/nodes.ts # packages/uilib/src/lib/plugins/communication-explorer/_func-layout-calculation/node-layout-connections.ts # packages/uilib/src/lib/plugins/communication-explorer/_func-layout-calculation/node-layout-ieds.ts # packages/uilib/src/lib/plugins/communication-explorer/_store-view-filter/selected-filter-store-functions.ts # packages/uilib/src/lib/plugins/communication-explorer/_store-view-filter/selected-filter-store.ts # packages/uilib/src/lib/plugins/communication-explorer/sidebar/ied-accordion/ied-accordion.svelte # packages/uilib/src/lib/plugins/communication-explorer/telemetry-view/telemetry-view.svelte
# Conflicts: # packages/uilib/src/lib/components/diagram/nodes.ts # packages/uilib/src/lib/plugins/communication-explorer/_func-layout-calculation/node-layout-ieds.ts # packages/uilib/src/lib/plugins/communication-explorer/sidebar/ied-accordion/ied-accordion.svelte
4 tasks
# Conflicts: # packages/uilib/src/lib/components/diagram/nodes.ts # packages/uilib/src/lib/plugins/communication-explorer/_func-layout-calculation/node-layout-ieds.ts
# Conflicts: # packages/uilib/src/lib/components/diagram/ied-element/ied-element.svelte
michelguerin
requested changes
Feb 21, 2025
packages/uilib/src/lib/plugins/communication-explorer/telemetry-view/telemetry-view.svelte
Show resolved
Hide resolved
|
i found and fixed 2 bugs that caused strange behavior, it should be working as intended now |
trusz
approved these changes
Feb 25, 2025
michelguerin
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒 Description
adding baylabels + ability to toggle between baycontainers & baylabels
clicking on a baylable selects all corresponding IEDs, similar to sidebar bay selection
📷 Demo screen recording or Screenshots
OpenSCD.Mozilla.Firefox.2025-02-20.16-47-17.mp4
📋 Checklist
You may remove tasks that do not make sense in this PR.
🔦 Useful commits
You can add specific commits which are worth taking a look into