Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gem2 installer to use gem2.0. #210

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

weakish
Copy link
Contributor

@weakish weakish commented May 3, 2016

Same as gem installer except it uses gem2.0.

Same as gem installer except it uses `gem2.0`.
@joshgoebel
Copy link
Contributor

This should be handled by gem supporting a :binary_name option that changes the default from gem to gem2.0 and then someone who needs this can define a helper gem2 function that just calls gem but merges in the binary_name argument.

In fact I'd be ok with gem2 in the API, but it should be part of gem.rb, not a whole new thing.

Add a new option to Gem installer: `gem_command`.
@weakish
Copy link
Contributor Author

weakish commented Jul 11, 2016

it should be part of gem.rb

Merged into gem.rb

This should be handled by gem supporting a :binary_name option that changes the default from gem to gem2.0 and then someone who needs this can define a helper gem2 function

I implemented it as an option gem_command.

@joshgoebel
Copy link
Contributor

That's fine, but I also imagined you'd have a gem2 api call that provided an easy way to call it without having to know about the internals of gem_command.

@joshgoebel
Copy link
Contributor

Something like:

 def gem2(name, options = {}, &block)
    gem(name, options.merge(:gem_command => "gem2.0"), &block)
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants